User description

Summary

Follow-up fixes to the remediation code-action flow, surfaced by review of the fixFolder work (PR #1331). All are correctness/robustness fixes; ~217 lines of production change, the rest tests (outside-in TDD throughout).

• Restrict remediation quick-fixes to supported products. The filter let fully-fixable Open Source issues through and offered a RemediationAgentQuickFix the agent can't apply. Replaced the negated IaC bypass with an explicit product switch (Code when it has an AI fix; IaC) — OSS/Secrets/Unknown excluded.
• Propagate the codeAction/resolve context to the provider. The deferred edit ran with context.Background(), so cancelling a resolve didn't stop the remediation. The deferred-edit type now carries a context.Context threaded to Remediate; nil deferred edits are guarded in both the resolve and AI-fix paths.
• Make the code-action cache concurrency-safe. actionsCache was an unsynchronised map read by codeAction/resolve and written by textDocument/codeAction. Added a mutex covering every access; the entry is read and (via defer) deleted under the lock, with the slow edit run lock-free — so a concurrent retry still finds the entry and the entry is always cleaned up, even on panic.
• FixFolder rejects a dirty worktree (git status --porcelain --untracked-files=no) so it can't silently fold pre-existing tracked changes into its result, while ignoring untracked artifacts.
• Gate the snyk.remediationAgent.fixFolder command advertisement on the feature flag (exported RemediationAgentEnabledKey shared with the DI gate). Fixed the filtered-issue debug count; removed the unused NoopProvider.

PR Stack — Merge Order

flowchart LR
    main(["main"])
    PR0["#1330\nremy unit tests"]
    PR1["#1331\nfixFolder + remy integ/smoke + cross-platform"]
    PR2["← YOU ARE HERE\nremediation code-action follow-up fixes"]
    main --> PR0 --> PR1 --> PR2
    style PR2 fill:#ffd700,color:#000

Depends on: #1331

Note on size

780 changed lines, but 217 are production and ~563 are tests (TDD acceptance/unit + a -race regression test for the cache). Kept as one cohesive bug-fix set rather than fragmenting the review.

Test plan

• CI green

PR Type

Enhancement, Bug fix

Description

• Improve remediation code action robustness and concurrency.

• Enhance context propagation to remediation providers.

• Add product filtering for remediation actions.

• Strengthen FixFolder command preconditions and error handling.

Diagram Walkthrough

flowchart LR
  subgraph LSP Client
    Client["Client"]
  end
  subgraph Snyk LS Server
    A[textDocument/codeAction] --> B(CodeActionService.GetCodeActions);
    B --> C{IssuesProvider};
    B --> D[remediationCodeActions];
    D -- Filters --> E(Product Check);
    B --> F(cacheCodeAction);
    F -- Mutex --> G[(actionsCache)];
    H[codeAction/resolve] --> I(CodeActionService.ResolveCodeAction);
    I -- Read/Unlock --> G;
    I -- Pass Context --> J(DeferredEdit);
    I -- Mutex --> G;
    K[FixFolder Command] --> L(Remediator.FixFolder);
    L -- Git Checks --> M{Worktree Status};
    N[Initialize Server] --> O{ExecuteCommandProvider};
    O -- Conditionally adds --> P[RemediationAgentFixFolderCommand];
  end
  Client -- Request --> A;
  Client -- Request --> H;
  Client -- Execute --> K;